Skip to content

Commit

Permalink
Merge pull request #33966 from code-dot-org/dtp_candidate_543b9752
Browse files Browse the repository at this point in the history
DTP (Test > Production: 543b975)
  • Loading branch information
breville committed Apr 1, 2020
2 parents 20107af + aa0ad01 commit 7c0be00
Show file tree
Hide file tree
Showing 721 changed files with 8,150 additions and 4,313 deletions.
4 changes: 2 additions & 2 deletions apps/i18n/common/bg_bg.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/ca_es.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/de_de.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/el_gr.json
Git LFS file not shown
5 changes: 3 additions & 2 deletions apps/i18n/common/en_us.json
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@
"builtOnCodeStudio": "Built on Code Studio",
"by": "By",
"cancel": "Cancel",
"cannotDeleteLibrary": "You cannot delete preset libraries",
"cannotDeleteUsedImage": "You cannot delete images that are currently used in your project",
"catActions": "Actions",
"catColour": "Color",
Expand Down Expand Up @@ -1519,7 +1520,7 @@
"stringEquals": "string=?",
"student": "Student",
"studentAnnouncementSpecial2020Heading": "Learn computer science when schools are closed",
"studentAnnouncementSpecial2020Description": "You can continue to learn at home while schools are closed. Try out fun computer science tutorials, watch videos about computer science concepts, and even build your own projects!",
"studentAnnouncementSpecial2020Body": "Students can continue to learn at home while schools are closed. Take a Code Break with us, or see resources for students, parents, and teachers - including videos, fun tutorials, and projects!",
"studentAnnouncementSpecial2020Button": "Get started",
"students": "Students",
"studentFreeResponseAnswers": "Student free response answers",
Expand Down Expand Up @@ -1563,7 +1564,7 @@
"teacher": "Teacher",
"teacherWithColon": "Teacher:",
"teachers": "Teachers",
"teacherAnnouncementSpecial2020Description": "We want to support teachers and parents during the current widespread school closures. Here are some resources to help students continue learning at home. We will continue to update these over time.",
"teacherAnnouncementSpecial2020Body": "Students can continue to learn at home while schools are closed. Take a Code Break with us, or see resources for students, parents, and teachers - including videos, fun tutorials, and projects!",
"teacherAnnouncementSpecial2020Heading": "Continued learning when schools are closed",
"teacherComments": "Teacher comments",
"teacherCommunity": "Teacher Community",
Expand Down
4 changes: 2 additions & 2 deletions apps/i18n/common/es_es.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/es_mx.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/et_ee.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/fr_fr.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/ga_ie.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/hi_in.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/hu_hu.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/id_id.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/is_is.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/it_it.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/ja_jp.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/mi_nz.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/mn_mn.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/my_mm.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/nn_no.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/no_no.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/pl_pl.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/pt_br.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/pt_pt.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/ru_ru.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/sk_sk.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/sv_se.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/tr_tr.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/vi_vn.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/zh_cn.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/common/zh_tw.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/maze/sk_sk.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/studio/sk_sk.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/studio/ta_in.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/studio/uk_ua.json
Git LFS file not shown
4 changes: 2 additions & 2 deletions apps/i18n/tutorialExplorer/my_mm.json
Git LFS file not shown
7 changes: 7 additions & 0 deletions apps/src/blockTooltips/DropletBlockTooltipManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,13 @@ DropletBlockTooltipManager.prototype.installTooltipsForCurrentCategoryBlocks_ =
const hoverDivRect = blockHoverDiv.getBoundingClientRect();
const toolboxRight = $('.droplet-palette-scroller').width();
const offsetX = Math.min(hoverDivRect.width, toolboxRight);
if (offsetX === 0) {
// This happens when we start in design mode and the toolbox hasn't yet
// rendered. In this case, skip installing the tooltips. We can try
// again when the student switches to code mode and this method is
// called again.
return;
}

// Vertically center the tooltip on the block it belongs to.
//
Expand Down
16 changes: 15 additions & 1 deletion apps/src/code-studio/components/libraries/LibraryListItem.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,12 @@ const styles = {
':hover': {
color: color.white,
backgroundColor: color.dark_red
},
':disabled': {
color: color.light_gray,
borderColor: color.light_gray,
backgroundColor: color.lightest_gray,
cursor: 'default'
}
}
};
Expand Down Expand Up @@ -141,12 +147,20 @@ export class LibraryListItem extends React.Component {
</button>
)}
{this.props.onRemove && (
<Tooltip text={i18n.removeFromProject()} place="bottom">
<Tooltip
text={
library.fromLevelbuilder
? i18n.cannotDeleteLibrary()
: i18n.removeFromProject()
}
place="bottom"
>
<button
type="button"
key={'remove-' + library.id}
onClick={() => this.props.onRemove(library.name)}
style={[styles.actionBtn, styles.removeBtn]}
disabled={!!library.fromLevelbuilder}
>
<FontAwesome icon="trash-o" style={styles.iconPadding} />
</button>
Expand Down
5 changes: 3 additions & 2 deletions apps/src/lib/kits/maker/MicroBitBoard.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,9 @@ export default class MicroBitBoard extends EventEmitter {
this.boardClient_.setPinMode(pin, modeConstant);
}

// TODO
digitalWrite(pin, value) {}
digitalWrite(pin, value) {
this.boardClient_.digitalWrite(pin, value);
}

// TODO
digitalRead(pin, callback) {
Expand Down
11 changes: 9 additions & 2 deletions apps/src/storage/dataBrowser/LibraryTable.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,16 @@ class LibraryTable extends React.Component {
})}
</span>
)}
<p>{datasetInfo.description}</p>
<span style={{display: 'block'}}>{datasetInfo.description} </span>

{datasetInfo.docUrl && (
<span style={{display: 'block'}}>
<a href={datasetInfo.docUrl}>{msg.moreInfo()}</a>
</span>
)}

{datasetInfo.sourceUrl && (
<span style={{display: 'inline-block'}}>
<span style={{display: 'block'}}>
{msg.dataSource() + ': '}
<a href={datasetInfo.sourceUrl}>
{datasetInfo.sourceText || datasetInfo.sourceUrl}
Expand Down
7 changes: 6 additions & 1 deletion apps/src/storage/dataBrowser/PreviewModal.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,12 @@ class PreviewModal extends React.Component {
return (
<BaseDialog isOpen handleClose={this.props.onClose} fullWidth fullHeight>
<h1>{this.props.tableName}</h1>
<p>{datasetInfo.description}</p>
<p>
{datasetInfo.description}{' '}
{datasetInfo.docUrl && (
<a href={datasetInfo.docUrl}>{msg.moreInfo()}</a>
)}
</p>
<div style={{overflow: 'scroll', maxHeight: '70%'}}>
<DataTable readOnly rowsPerPage={100} />
</div>
Expand Down
4 changes: 2 additions & 2 deletions apps/src/templates/studioHomepages/SpecialAnnouncement.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ export default class SpecialAnnouncement extends Component {
? i18n.teacherAnnouncementSpecial2020Heading()
: i18n.studentAnnouncementSpecial2020Heading();
const descriptionText = isTeacher
? i18n.teacherAnnouncementSpecial2020Description()
: i18n.studentAnnouncementSpecial2020Description();
? i18n.teacherAnnouncementSpecial2020Body()
: i18n.studentAnnouncementSpecial2020Body();
const buttonId = isTeacher
? 'teacher_homepage_announcement_special2020'
: 'student_homepage_announcement_special2020';
Expand Down

0 comments on commit 7c0be00

Please sign in to comment.