Merge pull request #40751 from code-dot-org/copy-level-with-lcd

When clone_with_suffix for level copy the level_concept_difficulty too
code-dot-org · May 27, 2021 · 829b035 · 829b035
2 parents eca8322 + cad9269
commit 829b035
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 39 deletions.
diff --git a/bin/curriculum/copy_level_concept_difficulties_between_years.rb b/bin/curriculum/copy_level_concept_difficulties_between_years.rb
diff --git a/dashboard/app/models/levels/level.rb b/dashboard/app/models/levels/level.rb
@@ -733,6 +733,12 @@ def clone_with_suffix(new_suffix, editor_experiment: nil)
     end
 
     level.update!(update_params)
+
+    # Copy the level_concept_difficulty of the parent level to the new level
+    new_lcd = level_concept_difficulty.dup
+    level.level_concept_difficulty = new_lcd
+    level.save! if level.changed?
+
     level
   end
 

diff --git a/dashboard/test/models/level_test.rb b/dashboard/test/models/level_test.rb
@@ -940,6 +940,23 @@ def create_maze
     assert_equal contained_level_2_copy, level_2_copy.contained_levels.last
   end
 
+  test 'clone with suffix copies level concept difficulty' do
+    level_1 = create :level, name: 'level 1'
+    level_1.assign_attributes(
+      'level_concept_difficulty' => {'sequencing' => 3, 'debugging' => 5}
+    )
+
+    refute_nil level_1.level_concept_difficulty
+    assert_equal 3, level_1.level_concept_difficulty.sequencing
+    assert_equal 5, level_1.level_concept_difficulty.debugging
+
+    level_1_copy = level_1.clone_with_suffix(' copy')
+
+    refute_nil level_1_copy.level_concept_difficulty
+    assert_equal 3, level_1_copy.level_concept_difficulty.sequencing
+    assert_equal 5, level_1_copy.level_concept_difficulty.debugging
+  end
+
   test 'clone with suffix sets editor experiment' do
     old_level = create :level, name: 'old level'
     new_level = old_level.clone_with_suffix(' copy', editor_experiment: 'level-editors')