Merge pull request #29061 from code-dot-org/uncomment-school-seeding

Uncomment school seeding
code-dot-org · Jun 11, 2019 · d8ef75f · d8ef75f
2 parents 3e20b97 + a620f80
commit d8ef75f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/dashboard/app/models/school.rb b/dashboard/app/models/school.rb
@@ -99,12 +99,8 @@ def self.seed_all(options = {})
       School.transaction do
         merge_from_csv(schools_tsv)
       end
-      # this also needs to be commented out to prevent seeding
-      # of new schools until school_districts table is updated
-      # b/c we'll get foreign key errors if this were to be executed
-      # (i.e., schools added without appropriate school districts)
-      # else
-      #   School.seed_from_s3
+    else
+      School.seed_from_s3
     end
   end
 

diff --git a/dashboard/app/models/school_district.rb b/dashboard/app/models/school_district.rb
@@ -43,11 +43,8 @@ def self.seed_all(options = {})
       SchoolDistrict.transaction do
         merge_from_csv(school_districts_tsv)
       end
-      # Temporarily commenting out the case where we run the full seed_from_s3
-      # (i.e., in production) in order to separately run seed_from_s3
-      # manually so as not to slow down the production deploy.
-      # else
-      #   SchoolDistrict.seed_from_s3
+    else
+      SchoolDistrict.seed_from_s3
     end
   end