Use pusher-js 3.2.1 #10279
Merged
Use pusher-js 3.2.1 #10279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds [`pusher-js@3.2.1`](https://github.com/pusher/pusher-js) to our project and uses it in NetSim. This replaces pusher-js 2.2, which wasn't available as an NPM package so we were loading it from the Pusher CDN via a script tag in _apps_depedencies.html.haml. * Pro: Removes one external dependency (though we still depend on Pusher's servers in other ways) * Pro: Removes the action-at-a-distance / global Pusher being provided through a script tag instead of via an `import` statement. * Pro: Brings [more than a year of bugfixes](https://github.com/pusher/pusher-js/blob/master/CHANGELOG.markdown) in the `pusher-js` library into our project. * Con: Increases the size of our netsim bundle. * Con: Automated test coverage for Pusher integration isn't great, so any change includes the risk of irregular behavior at scale. Tested by loading NetSim locally (I have my local machine configured to connect to my own Pusher account) and monitoring the live Pusher connections and messages dashboard while I sent messages in the simulator. Everything looks good!
|
LGTM. Glad to have more things imported via npm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
pusher-js@3.2.1to our project and uses it in NetSim. This replaces pusher-js 2.2, which wasn't available as an NPM package so we were loading it from the Pusher CDN via a script tag in _apps_depedencies.html.haml.I was pleasantly surprised to find that we were not affected by any breaking API changes in the upgrade.
importstatement.pusher-jslibrary into our project.netsim.min.jsgrows by about 62k, from ~554k to ~616kpusher.min.jsv2.2 file we no longer download from Pusher's CDN is only 15.6kTested by loading NetSim locally (I have my local machine configured to connect to my own Pusher account) and monitoring the live Pusher connections and messages dashboard while I sent messages in the simulator. Everything looks good!