Makes bin/oneoff/migrate_old_when_run_blocks more performant. #12830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashercodeorg
commented
Jan 25, 2017
| where(id: slice_ids). | ||
| where("data LIKE '%flappy_whenRunButtonClick%'"). | ||
| each do |level_source| | ||
| # Migrate the data from the old block to the new block. |
There was a problem hiding this comment.
Given the relative infrequency of observed updates, there doesn't seem to be any benefit in batching the updates in a transaction, the bottleneck is the data LIKE '%flappy_whenRunButtonClick%' search.
Hamms
approved these changes
Jan 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds better logging to the console.