Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates scripts_controller_test to use keyword arguments. #12841

Merged
merged 1 commit into from Jan 25, 2017

Conversation

ashercodeorg
Copy link
Contributor

@ashercodeorg ashercodeorg commented Jan 25, 2017

Resolves the deprecation warning, removing spurious output from tests (that obscures failures).

DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
in favor of keyword arguments, and will be removed in Rails 5.1.

Output after fix (sans deprecations warnings).

$ bundle exec ruby -Itest test/controllers/scripts_controller_test.rb 
Ignoring db/schema_cache.dump because it has expired. The current schema version is 20170124145919, but the one in the cache is 20170117185757.
Started with run options --seed 17675

  32/32: [=============================================================================================================================================================] 100% Time: 00:01:48, Time: 00:01:48

Finished in 108.45993s
32 tests, 57 assertions, 0 failures, 0 errors, 0 skips

Copy link
Contributor

@wjordan wjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming the CI tests continue to pass, on this and future PRs of this sort) 👍

@ashercodeorg ashercodeorg merged commit 14f4292 into staging Jan 25, 2017
@ashercodeorg ashercodeorg deleted the fixDeprecationWarningScriptsController branch January 25, 2017 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants