Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide share and remix in levelbuilder #12973

Merged
merged 2 commits into from Feb 3, 2017

Conversation

cpirich
Copy link
Contributor

@cpirich cpirich commented Jan 31, 2017

  • Add a new hide_share_and_remix property on levels that derive from Blockly (includes droplet levels such as gamelab and applab) and Weblab. It modifies the toolbar much like the recent change for embed levels. Exposed it in levelbuilder for all of those types of levels
  • Fixed the way weblab generates its level_options to behave more like Blockly derived levels. In this case, it improves that handling of boolean level properties.
  • Fix files API error when uploading files with unknown mime types (e.g. a file with no extension): see https://app.honeybadger.io/projects/3240/faults/31733196

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (staging@d6a1dcd).


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6a1dcd...e4f9db4. Read the comment docs.

Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder at what point we stop and find a way to refactor project-level features like this (for applab/gamelab/weblab) into some sort of module we can mix-in as needed.

@cpirich cpirich merged commit be1d6dd into staging Feb 3, 2017
@cpirich cpirich deleted the hide_share_and_remix_in_levelbuilder branch February 3, 2017 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants