Concatenates markdown and text if both are present. #13042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM in terms of what gets dumped into DB. I'll leave the ruby to @Hamms |
Hamms
approved these changes
Feb 3, 2017
| end | ||
| if contained_question_text.nil? | ||
| return contained_question_markdown | ||
| end |
There was a problem hiding this comment.
might we want if contained_question_markdown.nil? || contained_question_markdown.empty??
There was a problem hiding this comment.
By default, I'll answer no, as an empty markdown meant something got saved to it. And this is edge-case enough, I don't think it warrants investigation of the subtleties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per request from @bakerfranke. In theory, this "shouldn't happen", though the system definitely allows for the question to live in both the text and the markdown.