Create AuthoredHintViewRequests only if current_user. #13179
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 2017-02-09, it was discovered that we have been creating
AuthoredHintViewRequest
records for all users, signed-in or non-signed-in. This PR makes it so that we only create records for signed-in users, the desired behavior.TODO(asher, hamms) (here and in follow-up PRs):
:bad_request
rather than:accepted
for non-signed-in users.AuthoredHintViewRequest
data from the DB associated with non-signed-in users.AuthoredHintViewRequest.user_id
a non-nullable column.Also includes readability and style cleanup.