Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Applab from playing sounds on reset #13185

Merged
merged 1 commit into from Feb 10, 2017
Merged

Conversation

caleybrock
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #13185 into staging will decrease coverage by -0.3%.

@@            Coverage Diff             @@
##           staging   #13185     +/-   ##
==========================================
- Coverage    58.05%   57.76%   -0.3%     
==========================================
  Files          711      706      -5     
  Lines        52122    51998    -124     
  Branches      1154     1140     -14     
==========================================
- Hits         30260    30035    -225     
- Misses       21657    21752     +95     
- Partials       205      211      +6
Flag Coverage Δ
#integration 49.76% <50%> (-0.03%)
#unit 40.82% <50%> (-0.6%)
Impacted Files Coverage Δ
apps/src/applab/applab.js 78.48% <50%> (+0.06%)
apps/src/lib/kits/maker/PlaygroundComponents.js 21.42% <ø> (-59.61%)
apps/src/templates/instructions/utils.js 31.25% <ø> (-28.01%)
apps/src/lib/kits/maker/api.js 50% <ø> (-14.71%)
apps/src/lib/kits/maker/LookbackLogger.js 55.55% <ø> (-11.12%)
apps/src/templates/watchers/Watchers.jsx 13.76% <ø> (-3.67%)
apps/src/maze/collector.js 92.1% <ø> (-2.34%)
apps/src/applab/dropletConfig.js 80.55% <ø> (-1.5%)
apps/src/lib/script-editor/FlexGroup.jsx 19.29% <ø> (-1.4%)
apps/src/code-studio/progressRedux.js 97% <ø> (-1.12%)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cc30e3...1687531. Read the comment docs.

@caleybrock caleybrock merged commit 855246f into staging Feb 10, 2017
@caleybrock caleybrock deleted the stop-playing-sounds branch February 10, 2017 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants