Fix bug allowing duplicate product registration form submissions #13290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… added missing name & email fields [ci skip]
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added missing name & email fields. The forms table has
nameandemailfields, which are automatically populated from form data calledname_sandemail_srespectively. They aren't really needed, but we might as well fill them in since we have the data.I tested this locally. Before setting the form's
source_id, even though the form wouldn't load a second time, the submit post could happen multiple times and succeed. After this change, subsequent posts for the same application fail with a 409 (conflict).I also tested the migration locally in various configurations, and verified that all of the duplicates in production share the exact same data, so they are indeed duplicate form posts and we won't lose anything by deleting the duplicates.