remove unnecessary quotes that aren't allowed in page title strings #13348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashercodeorg
approved these changes
Feb 21, 2017
| @@ -246,7 +246,7 @@ bg: | |||
| signup_submit_error_message: "Възникнала е грешка. Моля проверете дали всички задължителни полета са попълнени правилно." | |||
| signup_thank_you_header: "Благодаря ви, че регистрирахте събитие за Hour of Code." | |||
| signup_thank_you_message: 'Ние ще ви изпратим имейл за потвърждение с информация, която да ви помогне да започнете.' | |||
| map_title: "\"Часът на кода\" карта" | |||
There was a problem hiding this comment.
Is there a way to prevent this from recurring?
There was a problem hiding this comment.
It's hacky but we could do something like this for every page title?
title: "<%= hoc_s(:map_title).gsub(/"/,"\\\"") %>"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 2 occurrences of https://app.honeybadger.io/projects/34365/faults/31438380