get rid of level created for testing purposes #13398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What happens to the associated DB entry ( |
|
I think they still end up existing |
|
What do we gain from removing the level, then? |
|
Seems dirty to have things that say "DONTCOMMIT" in our repo. Perhaps makes it more explicit that the level is not in use (though the name should already accomplish that). I dont feel super strongly about this. Would you prefer I jus t leave it? |
|
Not necessarily, I'm just asking questions. Really, I'd like to have a way delete a level across all environments (both file and DB), as well as associated DB entries. Do as you please... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This level got created when I was testing something on LB, and should not have been committed.