Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ChatClient. #13414

Merged
merged 1 commit into from Feb 23, 2017
Merged

Create ChatClient. #13414

merged 1 commit into from Feb 23, 2017

Conversation

ashercodeorg
Copy link
Contributor

@ashercodeorg ashercodeorg commented Feb 23, 2017 •
edited

Since usage of HipChat is far-reaching, it seems easiest and safest to create another class (ChatClient), then (possibly simultaneously) convert users of HipChat to ChatClient and clean up ChatClient.

Thus, this PR takes the initial step of establishing the new ChatClient class. The file is a copy of lib/cdo/hip_chat.rb, with all instances of HipChat in code changed to ChatClient.

aoby
aoby approved these changes Feb 23, 2017
View reviewed changes
Copy link
Contributor

@aoby aoby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All instances changed from hip_chat to chat_client except for the public method names (for now)

@ashercodeorg
Copy link
Contributor Author

Right, I did not change the public API method that mentions hip_chat.

@ashercodeorg ashercodeorg merged commit 62246b5 into staging Feb 23, 2017
@ashercodeorg ashercodeorg deleted the renameHipChat branch February 23, 2017 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoby aoby aoby approved these changes

Assignees

@aoby aoby

Labels
code-hygiene
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashercodeorg @aoby