Move slackify from ChatClient to Slack. #13415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoby
approved these changes
Feb 23, 2017
|
Because calls to |
ashercodeorg
commented
Feb 23, 2017
| gsub(/<a href=['"]([^'"]+)['"]>/, '<\1|'). | ||
| gsub(/<\/a>/, '>'). | ||
| gsub(/<br\/?>/, "\n") | ||
| Slack.message message.to_s, channel: channel, username: @@name, color: options[:color] |
There was a problem hiding this comment.
TODO(asher): Determine whether the typecast to a string is required. It makes sense that all messages should be a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From a design viewpoint, the
ChatClientshould not be concerned with how text should be sent to Slack, thus the refactor.Note that this means calls to
HipChat#messagewill be slackified twice. This seems safe, though technically theslackifymethod is not idempotent.