Fix bug in cohorts controller that failed to update when a teacher email was missing #13424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error in the wild
And sure enough, the unit test I just added failed with:
The solution was straightforward. In
update_teachers
, the teachers param lists is mapped intoUser
models representing the teachers, found or created on the fly, unless email is blank in which case that entry is nil. Then, later processing blew up on the nil User. Fix was simply compacting the user list to remove nils.