Fix skipping asset maps and reduce test state leakage #13467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
force-pushed
the
fix-skip-asset-map
branch
from
55df21f
to
30bc864
Compare
aoby
approved these changes
Feb 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two things related to asset maps:
CDO.pegasus_skip_asset_mapwas passing tests but didn't actually work in local development -- it was giving urls likehttp://localhost.code.org:3000/js/en_us/tutorialExplorer_locale.js(which are broken) instead ofhttp://localhost-studio.code.org:3000/assets/js/en_us/tutorialExplorer_locale.jsThanks @aoby for tracking down the fix for testing singletons 馃憦