Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove school district requirement from TeacherCon registration form #13471

Merged
merged 1 commit into from Feb 27, 2017

Conversation

aoby
Copy link
Contributor

@aoby aoby commented Feb 27, 2017

To allow for private schools, which don't have districts.

This was causing a validation failure on the invisible school_district_s field, and breaking the form:
image

I just removed school_district_s entirely. We have the application id, so can always go back and retrieve school and any other information from the application directly when we process these (a future work item).

Manually tested locally

…(private schools don't have district) [ci skip]
@aoby aoby added the bug-fix label Feb 27, 2017
@aoby aoby requested a review from mehalshah February 27, 2017 21:22
@mehalshah
Copy link
Contributor

LGTM

@aoby aoby merged commit 85faec6 into staging Feb 27, 2017
@aoby aoby deleted the pd-registration-form-no-school-district branch February 27, 2017 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants