Allow resizing of CSF contained levels #13543
Conversation
| paddingTop: CONTAINED_LEVEL_PADDING, | ||
| paddingLeft: CONTAINED_LEVEL_PADDING, | ||
| paddingRight: CONTAINED_LEVEL_PADDING, | ||
| }, |
There was a problem hiding this comment.
nit: might be more extensible to put these into a containedLevelStyles object, a la the craftStyles
| @@ -1791,6 +1791,10 @@ a.download-video { | |||
| box-sizing: border-box; | |||
| } | |||
|
|
|||
| .contained-level .free-response .response { | |||
| resize: vertical; | |||
| } | |||
There was a problem hiding this comment.
why is this here and not in an apps stylesheet?
There was a problem hiding this comment.
Mainly because this is where the rest of the free response level styling is.
There was a problem hiding this comment.
Man, our CSS needs some normalization. This is a fine place, in that case.
| </div> | ||
| {!this.props.collapsed && !this.props.isEmbedView && | ||
| <HeightResizer | ||
| position={this.props.height} | ||
| onResize={this.handleHeightResize} | ||
| style={styles.heightResizer} |
There was a problem hiding this comment.
HeightResizer doesn't have a style property; what is this intended to do?
There was a problem hiding this comment.
I added support for it in this PR. Is it bad practice to add a style property to react components?
There was a problem hiding this comment.
Oh! Wow, I totally missed that. Nope, what you did is perfect.
The HeightResizer actually works now (it used to be fixed in place, since both the minHeight and maxHeight were set to the height of the contained level), with scrolling when you make it smaller.