Teacher UI in progress redesign #13566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Bjvanminnen
commented
Mar 2, 2017
Bjvanminnen
commented
Bjvanminnen
commented
Mar 2, 2017
| rightCol: { | ||
| display: 'table-cell', | ||
| verticalAlign: 'top', | ||
| // TODO - fixed width will likely get us into trouble for other languages |
There was a problem hiding this comment.
think about this some more brent
Bjvanminnen
commented
Mar 2, 2017
| @@ -0,0 +1,74 @@ | |||
| /** | |||
There was a problem hiding this comment.
Potentially contentious decision here and with HiddenStageToggle to name a component identically to the component it is replacing (the difference being where they live).
islemaster
reviewed
Mar 3, 2017
apps/src/redux.js
Outdated
| @@ -61,19 +61,32 @@ if (IN_UNIT_TEST) { | |||
| }; | |||
| } | |||
|
|
|||
| if (IN_STORYBOOK) { | |||
| // Storybooks need the ability to create multiple distinct stores instead of | |||
| // using a singletone | |||
There was a problem hiding this comment.
Singletone 🎶 or singleton?
islemaster
reviewed
Mar 3, 2017
| */ | ||
| function createStoreWithReducers() { | ||
| return createStore(Object.keys(globalReducers).length > 0 ? | ||
| redux.combineReducers(globalReducers) : s => s); |
There was a problem hiding this comment.
Weird... how is line 84 covered but line 85 is not?
islemaster
reviewed
Mar 3, 2017
| @@ -122,6 +122,7 @@ var storybookConfig = _.extend({}, baseConfig, { | |||
| new webpack.ProvidePlugin({React: 'react'}), | |||
| new webpack.DefinePlugin({ | |||
| IN_UNIT_TEST: JSON.stringify(false), | |||
| IN_STORYBOOK: JSON.stringify(true), | |||
There was a problem hiding this comment.
I'm surprised storybook doesn't already provide this somehow, but I looked around and it doesn't seem to. 👍
islemaster
reviewed
Mar 3, 2017
| }, | ||
| }; | ||
|
|
||
| const HiddenStageToggle = React.createClass({ |
There was a problem hiding this comment.
Might not be worth it yet, but I bet extracting a generic toggle component in this new style will be useful down the road.
islemaster
approved these changes
Mar 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.