Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add console output. #13574

Merged
merged 2 commits into from Mar 13, 2017
Merged

Add console output. #13574

merged 2 commits into from Mar 13, 2017

Conversation

ashercodeorg
Copy link
Contributor

Also creates a main method, hooks up cdo/only_one, prompts for confirmation, and prevents running in some environments.

Copy link
Contributor

@ewjordan ewjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming this always gets run interactively (and it's not something that we'd call from Slack or something like that)

end

print "Kill tests on #{rack_env}? (Y/N): "
return unless gets.chomp.upcase == 'Y'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this always invoked in interactive mode?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Now that you mention it, I think it can be run via some slack integration. Not sure how that works... Let me find out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, AFAICT. The /restart-test-build command in Slack POSTs to https://test.code.org/api/dev/start-build, which does not use this script.

@ashercodeorg
Copy link
Contributor Author

+davidsbailey, the author of the script. For some reason I thought ewjordan was, thus my assigning him.

@davidsbailey
Copy link
Member

LGTM

@ashercodeorg ashercodeorg force-pushed the logKillTests branch 2 times, most recently from 171a78d to 09f91aa Compare March 13, 2017 18:18
@ashercodeorg ashercodeorg merged commit 5d067b3 into staging Mar 13, 2017
@ashercodeorg ashercodeorg deleted the logKillTests branch March 13, 2017 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants