New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add console output. #13574
Add console output. #13574
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming this always gets run interactively (and it's not something that we'd call from Slack or something like that)
end | ||
|
||
print "Kill tests on #{rack_env}? (Y/N): " | ||
return unless gets.chomp.upcase == 'Y' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this always invoked in interactive mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. Now that you mention it, I think it can be run via some slack integration. Not sure how that works... Let me find out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is, AFAICT. The /restart-test-build
command in Slack POSTs to https://test.code.org/api/dev/start-build, which does not use this script.
+davidsbailey, the author of the script. For some reason I thought ewjordan was, thus my assigning him. |
LGTM |
171a78d
to
09f91aa
Compare
09f91aa
to
d6627ee
Compare
Also creates a
main
method, hooks upcdo/only_one
, prompts for confirmation, and prevents running in some environments.