Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add difficulty param to proficient?. #13605

Merged
merged 1 commit into from Mar 6, 2017
Merged

Add difficulty param to proficient?. #13605

merged 1 commit into from Mar 6, 2017

Conversation

ashercodeorg
Copy link
Contributor

Related to PR #13601.

Hamms
Hamms approved these changes Mar 6, 2017
View reviewed changes
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

As an aside, can takes one and two now be removed, and this script renamed to just user_proficiencies?

@ashercodeorg
Copy link
Contributor Author

SGTM, I'll do so in another PR.

@ashercodeorg ashercodeorg merged commit bb430c6 into staging Mar 6, 2017
@ashercodeorg ashercodeorg deleted the proficiency branch March 6, 2017 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hamms Hamms Hamms approved these changes

Assignees

@Hamms Hamms

Labels
data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashercodeorg @Hamms