Volunteer forms: add 18+ declarations & make various fixes #13643
Conversation
| @@ -19,6 +19,7 @@ def self.normalize(data) | |||
| result[:skype_s] = nil_if_empty stripped data[:skype_s] | |||
| result[:helpouts_s] = nil_if_empty stripped data[:helpouts_s] | |||
|
|
|||
| result[:age_18_plus_b] = required data[:age_18_plus_b] | |||
There was a problem hiding this comment.
Added for completeness although this code does not appear to be called, due to the override in volunteer_engineer_submission_2015.rb
| %label{style: 'font-weight: normal;', for: 'volunteer-age-18-plus'} | ||
| %input#volunteer-age-18-plus{name: 'age_18_plus_b', type: 'checkbox', value: '1', required: true, checked: true} | ||
| = "I certify that I am at least 18 years old." # I18n.t(:volunteer_engineer_submission_checkbox_age_18_plus) | ||
|
|
There was a problem hiding this comment.
Is the plan to put this in the en.yml so it can be translated later?
There was a problem hiding this comment.
Oops yes, updating now. It will come from the i18n gsheet.
| .help-choice { | ||
| font-family: 'Gotham 4r', sans-serif; | ||
| } | ||
|
|
There was a problem hiding this comment.
Please move this CSS outside of this file, especially as it contains none yet.
|
Do we have any concerns about making the 18+ a required choice (from a UX perspective)? Might it be better to allow the user to submit with or without it, taking them to a "thanks but no thanks" page if unselected? |
|
I would prefer that we make it required. I think it's misleading if they're able to submit the form and go to another page. There's no guarantee they'll read what's on the next page and they may believe that they successfully signed up. |
|
And I think it is bad UX if we require a checkbox that the user may not be able to (honestly) check. That said, since most of volunteers should be 18+, I won't block this. |
Change #13643 added support for a new field that declares that the volunteer is 18+. This caused an issue for the user experience in which a volunteer would attempt to unsubscribe at /volunteer/engineer/edit/[secret]. Attempting to unsubscribe would give an error, internally this was because the form wanted to know that the user was 18+. This solution detects users who have not yet declared themselves as 18+ when showing the unsubscribe UI, and shows a checkbox for them. If they attempt to submit the unsubscribe form without this checked, they will get a specific error message. The unsubscribe form itself continue to not require an unsubscribe radio button to be checked, at least on the server-side processing of the form, and if no item is selected, then we write null to the database for their unsubscribe choice. This has an odd side effect of allowing users to submit their 18+ status via the unbsubscribe form without actually unsubscribing, but we've deemed this okay. The regular error message for this form now has a clickable link to open a support ticket.
For volunteers
For contacting a volunteer