Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete early backfill_data/user_proficiency takes. #13657

Merged
merged 2 commits into from Mar 8, 2017
Merged

Delete early backfill_data/user_proficiency takes. #13657

merged 2 commits into from Mar 8, 2017

Conversation

ashercodeorg
Copy link
Contributor

@ashercodeorg ashercodeorg commented Mar 8, 2017 •
edited

Though the deleted scripts were run in production, the data created and imported by them was truncated in lieu of the "take three" script. Thus the deleted scripts serve no historical purpose, so are being deleted (as suggested by @Hamms).

Though GitHub may not recognize it, this PR is the result of deleting the files user_proficiencies and user_proficiencies_take_two and renaming user_proficiencies_take_three to user_proficiencies.

Hamms
Hamms approved these changes Mar 8, 2017
View reviewed changes
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for cleanup!

@ashercodeorg ashercodeorg merged commit d1fcb7a into staging Mar 8, 2017
@ashercodeorg ashercodeorg deleted the cleanupUserProficiency branch March 8, 2017 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hamms Hamms Hamms approved these changes

Assignees

@Hamms Hamms

Labels
code-hygiene
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashercodeorg @Hamms