Fix deploy_to_test bugs and define DEVELOPERS. #13681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashercodeorg
commented
Mar 8, 2017
| @@ -1,40 +1,42 @@ | |||
| #!/usr/bin/env ruby | |||
|
|
|||
| require_relative '../../deployment' | |||
There was a problem hiding this comment.
Necessary for the cdo requires to be found.
ashercodeorg
commented
Mar 8, 2017
| raise unless current_topic.include? TOPIC_DTT_YES | ||
| new_topic = current_topic.gsub(TOPIC_DTT_YES, TOPIC_DTT_IN_PROGRESS) | ||
| Slack.update_topic(new_topic) | ||
| Slack.update_topic(DEVELOPERS, new_topic) |
There was a problem hiding this comment.
Oops, update topics require a room.
ashercodeorg
commented
Mar 8, 2017
| end | ||
|
|
||
| def main | ||
| unless dtt_yes? | ||
| ChatClient.message( | ||
| 'infra-test', | ||
| "robo-DTT skipped (\#developers topic is #{current_topic}).", | ||
| 'robo-DTT skipped (DTT was not yes)', |
There was a problem hiding this comment.
Oops, after some refactor change, current_topic is not defined in this scope.
ashercodeorg
commented
Mar 8, 2017
| @@ -52,7 +54,7 @@ def main | |||
| raise Exception.new('GitHub.create_and_merge_pull_request failed.') | |||
| end | |||
|
|
|||
| ChatClient.mesage( | |||
| ChatClient.message( | |||
There was a problem hiding this comment.
Oops, spelling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really, the DEVELOPERS string should be in
ChatClientorSlack. This is planned in another PR, encompassing not just these usages but all usages of room names across our codebase.