Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix method name (add missing scheduled). #13942

Merged
merged 2 commits into from
Mar 23, 2017
Merged

Fix method name (add missing scheduled). #13942

merged 2 commits into from
Mar 23, 2017

Conversation

ashercodeorg
Copy link
Contributor

@ashercodeorg ashercodeorg commented Mar 22, 2017 •
edited

mehalshah
mehalshah approved these changes Mar 22, 2017
View reviewed changes
Copy link
Contributor

@mehalshah mehalshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - should a test have caught this?

@ashercodeorg
Copy link
Contributor Author

No idea, re: test. This isn't "my" code.

@ashercodeorg
Copy link
Contributor Author

It appears that the test contained the same mistake. PTAL.

mehalshah
mehalshah approved these changes Mar 22, 2017
View reviewed changes
Copy link
Contributor

@mehalshah mehalshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashercodeorg
Copy link
Contributor Author

CircleCI failures seem unrelated.

@ashercodeorg ashercodeorg merged commit 3b1b02a into staging Mar 23, 2017
@ashercodeorg ashercodeorg deleted the addMissingScheduled branch March 23, 2017 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehalshah mehalshah mehalshah approved these changes

Assignees

@mehalshah mehalshah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashercodeorg @mehalshah