Make further progress deprecating Follower.user_id. #13945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashercodeorg
force-pushed
the
followerNextStep
branch
from
0ee9ffa
to
33ddc69
Compare
ashercodeorg
changed the title
ashercodeorg
force-pushed
the
followerNextStep
branch
from
71d3229
to
89fdea1
Compare
ashercodeorg
force-pushed
the
followerNextStep
branch
from
89fdea1
to
00b0d74
Compare
ashercodeorg
commented
Mar 28, 2017
| section_code: @laurel_section_2.code, | ||
| redirect: '/' | ||
| } | ||
| end |
There was a problem hiding this comment.
The test should create and destroy a Follower, so it is misleading to assert that it does not create one.
ashercodeorg
commented
Mar 29, 2017
| def add_student(student, move_for_same_teacher: true) | ||
| if move_for_same_teacher && (follower = student.followeds.find_by(user_id: user_id)) |
There was a problem hiding this comment.
As part of deprecating follower.user_id, this "search" no longer references follower.user_id.
ashercodeorg
force-pushed
the
followerNextStep
branch
from
2d74591
to
d078376
Compare
ashercodeorg
changed the title
aoby
approved these changes
Mar 30, 2017
|
FYI @davidwufer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More steps towards removing the
user_idcolumn in thefollowerstable.Follower.user_idinFactoryGirl.user_must_be_section_uservalidation onFollower.Section#add_studentto not go throughFollower.user_id.