Update sinon #13946
Merged
Update sinon #13946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
commented
Mar 22, 2017
| "Base64": "0.3.0", | ||
| "aws-sdk": "2.28.0", |
There was a problem hiding this comment.
Turns out yarn likes listing things alphabetically.
balderdash
approved these changes
Mar 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
sinonto 2.1.0 and makes a corresponding update tosinon-chaito 2.9.0. I'm doing this because I want to be able to usesinon.stub.resolves()andsinon.stub.rejects()for testing some promise-heavy code.I only found one deprecation that affected us (and it was only printing a warning, but I cleaned it up anyway):
stub(obj, 'methodName', func)is deprecated in favor of more idiomaticstub(obj, 'methodName').callsFake(func). It turns out most of the places we were doing this didn't really need a fake function anyway, they were returningundefined(which can just bestub(obj, 'methodName')) or a fixed value (stub(obj, 'methodName').returns(value)).