No empty descriptions in generated changelog

[islemaster]

For some reason we're seeing occasional empty PR descriptions in generated changelogs (example 1, example 2). It looks like this happens for PRs with titles "DTS (Levelbuilder > Staging)". I don't actually understand the root cause though.

In any case this makes it so we'll at least write "PR 00000" as the description in those cases, so the link is clickable, which seems like a good stopgap until we understand why those PR descriptions aren't getting picked up.

[Hamms]

LGTM! I'll be interested to see which PRs are failing; I think we filter out the various between-server PRs, so there might be something else breaking the regex.

[Hamms]

nit: I think the rubyesque way to do this would be description = "PR #{match['pr']}" if description.strip.empty?

[islemaster]

Ah, nice catch, I'll update.

[islemaster]

By 'editing' the release you can see the generated markdown for the blank lines, which is something like this:

- [](https://github.com/code-dot-org/code-dot-org/pull/13964)

I'll throw together a complete list of failure cases (there are only about ten) so we can figure this out.

[islemaster]

Complete list of failures:

Release	PR	Title
v2017-03-23.0	#13964	DTS (Levelbuilder > Staging)
v2017-03-22.0	#13941	DTS (Levelbuilder > Staging)
v2017-03-21.0	#13911	DTS (Levelbuilder > Staging)
v2017-03-20.1	#13877	DTS (Levelbuilder > Staging)
v2017-03-17.0	#13854	DTS (Levelbuilder > Staging)
v2017-03-16.0	#13830	DTS (Levelbuilder > Staging)
v2017-03-15.0	#13808	DTS (Levelbuilder > Staging)
v2017-03-15.0	#13795	DTS (Levelbuilder > Staging)
v2017-03-14.0	#13785	DTS (Levelbuilder > Staging)
v2017-03-13.1	#13764	DTS (Levelbuilder > Staging)
v2017-03-10.0	#13723	DTS (Levelbuilder > Staging)
v2017-03-09.0	#13698	DTS (Levelbuilder > Staging)

Well, that's conclusive. In releases earlier than this I believe the PRs were just named "Levelbuilder > Staging". Now to work out what the bad interaction with the regex is? The parens seem like a likely candidate.

[Hamms]

Ah, yeah, Asher's DotD script updates changed the naming scheme. Still, seems strange that this wouldn't work; the regex is pretty permissive.

[islemaster]

Interesting, the problem isn't the regex at all:

git log --merges --oneline production^1..production^2 --format="%s %b"

Isn't including the PR title in the merge commit description for DTLs anymore. Any ideas?

Merge pull request #13965 from code-dot-org/staging 
Merge pull request #13962 from code-dot-org/fixScript Fix script (remove old properties).
Merge pull request #13964 from code-dot-org/levelbuilder 
Merge pull request #13963 from code-dot-org/do-not-send-development-analytics Do not send analytics events in development or test
Merge pull request #13955 from code-dot-org/openid_connect_version fork omniauth-openid-connect
...

[Hamms]

Woah, funky. I assume it has something to do with the way the PRs are being merged; presumably the GH web interface adds the title to the commit, but the DotD script does not

Looks simple enough to modify the merge_pull_request method call to add the title as a commit description