Order i18n yml hashes #13982
Merged
Order i18n yml hashes #13982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we are in ruby > 1.9, hashes preserve the order in which keys are inserted, meaning that our YAML files containing translations have also been nicely ordered.
Unfortunately, this order was dependent on the order in which the files were returned from
Dir.glob, which is going to be different on HFS+ and ext filesystems (case-sensitive vs case-insensitive ordering).To prevent confusion and to allow flexibility in who calls this script while maintaining consistency, we
.sortthe files at the Ruby level before processing them.