Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Style/BracesAroundHashParameters to rubocop blacklist. #14009

Merged
merged 1 commit into from Mar 27, 2017

Conversation

ashercodeorg
Copy link
Contributor

Note that none of the configuration options seem to make sense with our prevailing style and/or our beliefs about how things should be.

The default no_braces option would require eliminating braces in many contexts where their presence vastly improves readability by grouping the final hash parameters. The braces option would require adding braces in many contexts where doing so provides no benefit. And the context_dependent is the worst of both worlds.

@ashercodeorg ashercodeorg merged commit 2b3c0e0 into staging Mar 27, 2017
@ashercodeorg ashercodeorg deleted the rubocopBracesAroundHashParameters branch March 27, 2017 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants