PD Enrollment now automatically generates enrollment in plc #14041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoby
reviewed
Mar 28, 2017
| Pd::Workshop::COURSE_ECS, 'ECS Support', | ||
| Pd::Workshop::COURSE_CS_IN_A, 'CS in Algebra Support', | ||
| Pd::Workshop::COURSE_CS_IN_S, 'CS in Science Support' | ||
| ] |
There was a problem hiding this comment.
This mapping seems more related to workshop than enrollment, and should go with the other workshop constants in workshop.rb. It can be exposed via something like workshop.associated_online_course
Also why Hash[...] instead of {...}? And please .freeze the hash. See SECTION_TYPE_MAP for an example.
| def enroll_in_corresponding_online_learning | ||
| plc_course = Plc::Course.find_by( | ||
| name: WORKSHOP_COURSE_ONLINE_LEARNING_MAPPING[workshop.course] | ||
| ) |
There was a problem hiding this comment.
Like above, I think this find logic better belongs in the Workshop model. Encapsulate this in a method, something like workshop.associated_online_course that returns the matching PLC course or nil.
aoby
reviewed
Mar 28, 2017
dashboard/app/models/pd/workshop.rb
Outdated
| Pd::Workshop::COURSE_CSP => 'CSP Support', | ||
| Pd::Workshop::COURSE_ECS => 'ECS Support', | ||
| Pd::Workshop::COURSE_CS_IN_A => 'CS in Algebra Support', | ||
| Pd::Workshop::COURSE_CS_IN_S => 'CS in Science Support' |
There was a problem hiding this comment.
note now that this is in Pd::Workshop you don't need the prefix here
aoby
approved these changes
Mar 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.