Make it easier for students to sign in with word / picture passwords #14047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # if this is a picture or word section, redirect to the section login page so that the student | ||
| # does not have to type in the full URL | ||
| if @section && (@section.login_type == Section::LOGIN_TYPE_PICTURE || @section.login_type == Section::LOGIN_TYPE_WORD) |
There was a problem hiding this comment.
nit: My preference is for [Section::LOGIN_TYPE_PICTURE, Section::LOGIN_TYPE_WORD].include? @section.login_type.
wjordan
approved these changes
Mar 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://codeorg.axosoft.com/viewitem?id=642&type=features&force_use_number=true
From Josh S: In regards to joining sections, it's difficult for younger students to have to type in the full URL of studio.code.org/sections/ABCDEF. We have many requests to make this easier for students. It's almost ironic in that picture/word-based sections are meant to be easier, when it's in fact easier to visit code.org/join and enter a 6-character code - but that only works for email-based sections.
Spec (new behavior):
If you are signed out and the section is a word / picture type:
We should take you the page where you can log in with your word / picture password.