Maker: Enable/disable via settings cog #14118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caleybrock
reviewed
Apr 3, 2017
| return style; | ||
| }, | ||
|
|
||
| hideToolboxIcon() { |
There was a problem hiding this comment.
At first I thought these names were a little confusing because they seem like verbs, but I think it makes sense with the toggle function.
| @@ -90,7 +90,8 @@ Feature: App Lab Scenarios | |||
| @no_mobile | |||
| Scenario: Upload Image Asset | |||
| When I press "designModeButton" | |||
| And I press "manage-assets-button" | |||
| And I press the settings cog | |||
There was a problem hiding this comment.
Learned what a cog is today - I always just called it a gear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #14117, restoring #13958.
The original version of the feature broke applab/scenarios.feature, which does not run in Circle (disabled in #11908 due to high flakiness in that environment). Will be fixed by updating tests to use the settings cog to open the asset manager.