Don't shift undefined
into the actions list if the queue is empty
#14130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
TypeError: undefined is not an object (evaluating 'e.blockId')
on New Relic. The error occurs only on touch devices. I repro'd on iPhone by pressing "Step" twice in a row. https://rpm.newrelic.com/accounts/501463/browser/3787364/js_errors#id=2099206246Root cause is that iOS Safari doesn't respect
disabled
on HTML button elements. This meansgetActions
is called whenthis.steps_
is empty for the ExecutionInfo instance. As a result,this.steps_.shift()
returns undefined, which is then pushed into theactions
array.