Maker: Round scaled sensor values #14136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by curriculum:
sensor.value
should always return a round number after callingsetScale(0, 1023)
(which maps the normal 0-1023 range onto a different range). We're okay with the loss of precision inherent in this decision. (one-line spec)I wrote tests for this here, but to make the actual fix I had to fork johnny-five, because its
Sensor
component defines itsvalue
property in the constructor as a nonconfigurable getter that I can't modify, replace, or override with a subclass.