Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all unused vars from apps codebase #14304

Merged
merged 9 commits into from Apr 10, 2017
Merged

Remove all unused vars from apps codebase #14304

merged 9 commits into from Apr 10, 2017

Conversation

pcardune
Copy link
Contributor

And add linting to keep it that way!

Bjvanminnen
Bjvanminnen approved these changes Apr 10, 2017
View reviewed changes
Copy link
Contributor

@Bjvanminnen Bjvanminnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

var isApproved = true;
submit(true);

@pcardune pcardune merged commit 727a7a6 into staging Apr 10, 2017
@pcardune pcardune deleted the pcardune-no-unused-vars branch April 10, 2017 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bjvanminnen Bjvanminnen Bjvanminnen approved these changes

@islemaster islemaster Awaiting requested review from islemaster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pcardune @Bjvanminnen