Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clientside tests for Facilitator Program Registration #14385

Merged
merged 6 commits into from Apr 17, 2017
Merged

Add clientside tests for Facilitator Program Registration #14385

merged 6 commits into from Apr 17, 2017

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Apr 13, 2017

No description provided.

@Hamms Hamms requested a review from mehalshah April 13, 2017 21:53
@Hamms Hamms force-pushed the add_react_tests_for_FPR branch 4 times, most recently from 3adb954 to 852f8fb Compare April 13, 2017 23:58
mehalshah
mehalshah approved these changes Apr 14, 2017
View reviewed changes
apps/test/unit/facilitatorProgramRegistration.js Outdated
@@ -0,0 +1,235 @@
import {assert} from '../util/configuredChai';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think convention is to have the word test in the file name

apps/test/unit/facilitatorProgramRegistration.js Outdated
const DEFAULTS = {
apiEndpoint: "",
course: "",
options: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these options we can just import from the source js?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope! Options are by design actually supplied by the server (from Pd::FacilitatorProgramRegistration::OPTIONS)

apps/test/unit/facilitatorProgramRegistration.js Outdated
/>
);

// by default, "next" and not "submit"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably DRY this section. Your call if you want to do that

@Hamms Hamms merged commit dd1e9fc into staging Apr 17, 2017
@Hamms Hamms deleted the add_react_tests_for_FPR branch April 17, 2017 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehalshah mehalshah mehalshah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hamms @mehalshah