Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regional partner should be a required field #14427

Merged
merged 1 commit into from Apr 17, 2017
Merged

Regional partner should be a required field #14427

merged 1 commit into from Apr 17, 2017

Conversation

mehalshah
Copy link
Contributor

@mehalshah mehalshah commented Apr 17, 2017 •
edited by ashercodeorg

This migration is safe as there are currently no rows in the pd_payment_terms table, thus no rows where the existing value is NULL.

SELECT COUNT(0) FROM pd_payment_terms;
+----------+
| COUNT(0) |
+----------+
|        0 |
+----------+

ashercodeorg
ashercodeorg approved these changes Apr 17, 2017
View reviewed changes
Copy link
Contributor

@ashercodeorg ashercodeorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note that I filled in the PR summary. If my addition is not correct, my approval should not be assumed.

@mehalshah
Copy link
Contributor Author

Current assumption is correct. Payment Terms are currently unusued.

@mehalshah mehalshah merged commit 7365e22 into staging Apr 17, 2017
@davidsbailey davidsbailey deleted the require_regional_partner_in_payment_term branch August 8, 2017 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashercodeorg ashercodeorg ashercodeorg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mehalshah @ashercodeorg