New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more stuff to UserTest#setup_all. #14433
Conversation
Note that the last commit is a hack. Really, we should be changing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice cleanup!
user = create :student | ||
user.update!(races: %w(white black hispanic asian american_indian hawaiian)) | ||
assert_equal %w(nonsense), user.reload.races | ||
@student.reload.update!(races: %w(white black hispanic asian american_indian hawaiian)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious if the .reload
was added here for a necessary reason (no need to change since the tests are currently passing).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was flaky without it. Might be worth understanding why.
No description provided.