Eyes gem: Upgrade eyes_selenium gem to version 3.2.2

[breville]

As suggested by Applitools' support team.

(Gemfile.lock generated by running bundle install after making the change to Gemfile.)

[islemaster]

Wow, no other API changes in a major version upgrade?

[aoby]

LGTM. We should babysit the next DTT to make sure this doesn't cause regressions.

[islemaster]

Fun fact: This update includes my only Applitools bugfix which shipped in 2.39.0.

[islemaster]

Sorry, I'm going to investigate further for possible API changes before I approve. It's not just a major version, this gem has changed GitHub repositories (before, after) since our current version - who knows what that means 🤷‍♂️.

[islemaster]

Well, they definitely copied parts of the old repo over - here's the test I added, now attributed to an "initial import."

[islemaster]

Okay, I can't find anything in the documentation that suggests breaking changes and I'm not going to dig through everything in those two repos - running the tests is going to be our best validation. 👍

[islemaster]

Hmm, this is the thing I most expect to break:

  batch = Applitools::Base::BatchInfo.new(ENV['BATCH_NAME'])
  batch.id = ENV['BATCH_ID']
  @eyes.batch = batch

The Applitools::Base namespace is definitely documented for v2.38.0 but not for v3.2.1. The docs on the Applitools wiki still refer to Applitools::Base::BatchInfo but they also still use Applitools::Eyes.new instead of Applitools::Selenium::Eyes.new, leading me to believe those docs assume a 2.x version - so it's possible the API for setting up a test batch has changed entirely. I'll open a question on their new repo about this.

[islemaster]

Found it (while writing https://github.com/applitools/eyes.sdk.ruby/issues/28) - Applitools::Base::BatchInfo was moved to Applitools::BatchInfo. I'd update that in this PR too.

[davidsbailey]

Nice! LGTM. Anything in particular we're getting from eyes_selenium 3.2.1 to look forward to?

[breville]

@davidsbailey Nothing specific, but their support suggested we upgrade when we described the timeouts we saw in taking screenshots. If it doesn't solve this issue, then we can gather more logs and submit them.

Currently blocked on hearing from their support about an (as yet) undocumented API change.

[islemaster]

Looks like batch support in the new library has been merged and is landing in v3.2.2.