Add thumbnail images for Playlab projects #14578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bjvanminnen
reviewed
Apr 21, 2017
apps/src/studio/studioThumbnail.js
Outdated
| .then(canvasFromImage) | ||
| .then(createThumbnail) | ||
| .then(canvasToBlob) | ||
| .then(project.saveThumbnail); |
There was a problem hiding this comment.
Would it make sense to move more of this logic into imageUtils? i.e. have something like
captureSvgScreenshot(document.getElementById('svgStudio'), MIN_CAPTURE_INTERVAL_MS);
I suspect we will have other svg apps that could then reuse much of this?
Bjvanminnen
reviewed
Apr 21, 2017
| @@ -103,7 +104,6 @@ stage 'Pixelation' | |||
| level 'Pixelation - Lesson 14 - Make the Letter A' | |||
| level 'Pixelation - Lesson 15 - Complete 3-bit color' | |||
| level 'Pixelation - Lesson 15 - Color Shades 4x4' | |||
| level 'Pixelation - AllTheThings 4' | |||
There was a problem hiding this comment.
intentionally removing pixelation level?
Bjvanminnen
approved these changes
Apr 21, 2017
|
Good suggestion Brent. PTAL. There is more cleanup I can do affecting other app types, but it probably warrants a follow-on PR. |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a new project-backed playlab level, so that we can remix it to get a new project in the projects list for use in eyes tests.
The SVG capture process seems a little more CPU intensive than artist or gamelab, so only allow it once per minute.
expected new eyes baselines: https://eyes.applitools.com/app/sessions/00000251909492557021/00000251909492556129/steps/1?&parent=vos3oAR&accountId=mG4DoRfv0ntEgI3XIYBulrKxlZqrHtGwbP3V103ojvLFU110