Run eyes tests without diffs on Circle CI by default #14580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
changed the title
|
My 3 or so test runs showed this added 12 minutes to each circle build. are we cool with that? |
|
Oh, I see we wait for every last UI test to run before we start the eyes run. It seems like kicking off both suites in parallel, with less parallelism on each, might perform better. I'm also fine with shipping this now and optimizing later. |
davidsbailey
approved these changes
Apr 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Circle builds run eyes tests (without actually using Applitools) by default. This is really simple after @davidsbailey did the work of making this work again with the commit tag.
Tested over five builds: