Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test by removing dependency on (undefined) order of results #14609

Merged
merged 1 commit into from Apr 25, 2017
Merged

Fix flaky test by removing dependency on (undefined) order of results #14609

merged 1 commit into from Apr 25, 2017

Conversation

aoby
Copy link
Contributor

@aoby aoby commented Apr 24, 2017

This test has been failing sporadically recently. Example

@aoby aoby requested a review from Bjvanminnen April 24, 2017 20:14
Bjvanminnen
Bjvanminnen approved these changes Apr 24, 2017
View reviewed changes
Copy link
Contributor

@Bjvanminnen Bjvanminnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@aoby aoby merged commit f7f3018 into staging Apr 25, 2017
@aoby aoby deleted the fix-unordered-api-controller-test branch April 25, 2017 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bjvanminnen Bjvanminnen Bjvanminnen approved these changes

Assignees
No one assigned
Labels
bug-fix testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aoby @Bjvanminnen