Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate code.org/public/private/privileges/index.haml. #14636

Merged
merged 2 commits into from Apr 28, 2017

Conversation

ashercodeorg
Copy link
Contributor

@ashercodeorg ashercodeorg commented Apr 25, 2017

This page is being eliminated as similar functionality is now offered in #14615 via dashboard, where the implementation should exist.

In addition to eliminating the pegasus page, this PR updates the admin link to point to the dashboard page.

@ashercodeorg ashercodeorg changed the title Eliminate code.org/public/private/privileges/index.haml and transfer admin links. Eliminate code.org/public/private/privileges/index.haml. Apr 25, 2017
@joshlory joshlory self-assigned this Apr 26, 2017
@ashercodeorg
Copy link
Contributor Author

Ready for a look. Thanks!

@joshlory
Copy link
Contributor

Is anyone going to miss the ability to grant bulk permissions to many users at once? Looks like PR #14615 only allows 1 email at a time.

@ashercodeorg
Copy link
Contributor Author

Given how rare permission updates are (see Slack#infra-security), I'm not too concerned. If there is a need for multiple emails, I'll own adding that feature.

@ashercodeorg ashercodeorg merged commit 323bc00 into staging Apr 28, 2017
@ashercodeorg ashercodeorg deleted the killPegasusPrivs branch April 28, 2017 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants