Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove linklocal dependency #14661

Merged
merged 1 commit into from Apr 27, 2017
Merged

Remove linklocal dependency #14661

merged 1 commit into from Apr 27, 2017

Conversation

islemaster
Copy link
Contributor

Remove our dependency on linklocal. It looks like we've stopped using this. Removing it doesn't break our build, and has no measurable effect on build output size, and barely any impact on node_modules size.

@islemaster islemaster requested a review from wjordan April 26, 2017 01:06
Copy link
Contributor

@wjordan wjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC this was an npm-hack-workaround for lack of symlink support. looks like we stopped using this in recent iterations of our build pipeline since switching to yarn/karma/webpack. 👍

It looks like we've stopped using this. Removing it doesn't break our build, and has no measurable effect on build output size, and barely any impact on node_modules size.
@islemaster islemaster merged commit 57fe33d into staging Apr 27, 2017
@islemaster islemaster deleted the remove-linklocal branch April 27, 2017 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants