Update react-virtualized and react-virtualized-select #14737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
force-pushed
the
update-react-virtualized
branch
from
b356835
to
1e88480
Compare
Bjvanminnen
approved these changes
May 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More dependency updates that actually result in less dependencies. This one is an attempt to remove our last chained dependency on
react-addons-shallow-compareafter I noticed in #14720 that it was still apeerDependencyofreact-virtualized. We only usereact-virtualizedforreact-virtualized-select(we have to include it directly so we can use its stylesheets, see the suggested usage pattern so it makes sense to upgrade these together.