Remove dependency on user_type of create :user. #14752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashercodeorg
force-pushed
the
userMeansUser
branch
from
ebe752c
to
eefecb6
Compare
ashercodeorg
changed the title
ashercodeorg
commented
May 1, 2017
| refute ability.can?(:destroy, Level) | ||
| refute ability.can?(:destroy, Activity) | ||
|
|
||
| assert ability.can?(:read, Section) |
There was a problem hiding this comment.
Copied from "as student", with the can?(:read, Section) changed from refute to assert.
ashercodeorg
commented
May 1, 2017
| @@ -35,8 +35,8 @@ class AbilityTest < ActiveSupport::TestCase | |||
| refute ability.can?(:read, @login_required_script_level) | |||
| end | |||
|
|
|||
| test "as member" do | |||
| ability = Ability.new(create(:user)) | |||
There was a problem hiding this comment.
This test fails with create(:teacher).
ashercodeorg
commented
May 1, 2017
| @@ -25,7 +25,7 @@ class ApiControllerTest < ActionController::TestCase | |||
| # some of our tests depend on sorting of students by name, thus we name them ourselves | |||
| @students = [] | |||
| 5.times do |i| | |||
| student = create(:user, name: "student_#{i}") | |||
There was a problem hiding this comment.
This test fails with create(:teacher, name: "student_#{i}").
|
The eyes failures should be unrelated. |
aoby
approved these changes
May 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.