Remove Slack#server-operations notification on build success. #14753
Conversation
aws/ci_build
Outdated
| @@ -45,7 +45,7 @@ def upload_log_and_get_link(key, body, metadata) | |||
| body, | |||
| {metadata: metadata} | |||
| ) | |||
| " <a href='#{log_url}'>☁ Log on S3</a>" | |||
| " <a href='#{log_url}'> Log on S3</a>" | |||
There was a problem hiding this comment.
It goes against our styleguide of source code being in UTF8.
There was a problem hiding this comment.
Could we swap in the HTML escape? ☁
There was a problem hiding this comment.
Is it better to use the unicode escape or the HTML escape? Note that I chose the former, though I'm happy to do the latter if more appropriate.
And, out of playful curiosity, why do we mind the cloud disappearing?
There was a problem hiding this comment.
It's mostly for fun. I do think there's a little value in adding iconography to our Slack interface if it's not too noisy. I build subtle associations with these things (like tableflip guy when tests fail) so that, personally, I find things scan easier than if we just had a wall of text.
ashercodeorg
force-pushed
the
ciBuildOutput
branch
from
9980f69
to
1b117ec
Compare
There was a problem hiding this comment.
I don't agree that Slack#server-operations output needs be uniformly actionable (see my comment in the other PR for further discussion), just high signal-to-noise. In this case, although non-actionable, production-environment build notifications are low-volume and highly-relevant to our operations (e.g., for comparing against other error reports to determine if they occurred before/during/after a deploy), so I don't think they should be removed here.
I'm indifferent to non-production notifications (which are higher-volume and lower-relevance), so those can still be filtered if desired, as long as production notifications remain.
|
Done (adding logging for production environment). PTAL. |
aws/ci_build
Outdated
| ChatClient.log message, color: 'green' | ||
|
|
||
| ChatClient.message 'server operations', message, color: 'green' | ||
| ChatClient.message 'server operations', commit_url, color: 'gray', message_format: 'text' | ||
| if rack_env == 'production' |
There was a problem hiding this comment.
rack_env returns a Symbol, so this needs to be rack_env == :production or it will never be true
There was a problem hiding this comment.
Good catch. Done.
ashercodeorg
force-pushed
the
ciBuildOutput
branch
from
5e3658a
to
9597f3a
Compare
This PR is being done as the result of team interest in making all output to
Slack#server-operationsactionable. Note that error output will continue to go toSlack#server-operations, as action is appropriate in this case.Also see #14751.