[Playlab] Skip the command queue for score-changing blocks #14769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we have any test coverage for the various score blocks? I'm a little terrified about how this will change existing programs, but the new approach seems to be clearly better. |
|
CircleCI failure related? |
joshlory
approved these changes
May 2, 2017
balderdash
force-pushed
the
variablify-score
branch
from
2a7abc2
to
f1e7392
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for the
getScoreblock to work properly with other score-changing blocks, the score needs to be updated immediately like other variable blocks, not when the command queue executes as these score blocks currently do it.This was briefly discussed in https://github.com/code-dot-org/code-dot-org/pull/9756/files/eb5d1d504577494252e8935fdddea095a42c12bf#r73028339, but I didn't update the behavior of the existing score blocks in that PR.